Re: [PATCH] cpufreq: unlock when failing cpufreq_update_policy()

From: Viresh Kumar
Date: Wed Jun 18 2014 - 10:41:53 EST


On 18 June 2014 20:09, Aaron Plattner <aplattner@xxxxxxxxxx> wrote:
> I assume you meant "return -ENODEV"?

Yeah, sorry :)

>> down_write(&policy->rwsem);
>>
>> @@ -2279,10 +2277,10 @@ int cpufreq_update_policy(unsigned int cpu)
>>
>> ret = cpufreq_set_policy(policy, &new_policy);
>>
>> +no_policy:
>
>
> 'no_policy' implied to me that policy was NULL, so this label should still
> be renamed to 'unlock'. I'll send out a v2 that does this.

Yeah.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/