Re: [PATCH 0/3] blk-mq: bitmap tag: Fix few races

From: Jens Axboe
Date: Tue Jun 17 2014 - 23:12:25 EST


On 2014-06-17 10:39, Alexander Gordeev wrote:
On Tue, Jun 17, 2014 at 07:21:19AM -0600, Jens Axboe wrote:
On 2014-06-17 04:35, Christoph Hellwig wrote:
Jens, did you plan to pick these up? There's a few bits of low hanging
fruit for cleanups / micro-optimizations in this area, but I don't want
to create conflicts with Alexanders work.

I'm evaluating just getting rid of the cyclic waits, which is why
I've held off. But the patches don't apply to the current tree
anyway, so they would need a rediffing no matter what.

Hi Jens,

Patches 1/3 and 2/3 apply to Linus's tree and could go in without patch 3/3.
I'll post v2 of 3/3.

As mentioned in another thread, I'm sort-of hoping we can just get rid of the nasty multiple waitqueues. Will run some testing when I'm back. If we still see a nice gain of having the cycling waitqueues, then I'll test and apply your patches to close up the holes.


--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/