Re: [PATCH v4] hwmon: Driver for TI TMP103 temperature sensor

From: Guenter Roeck
Date: Tue Jun 17 2014 - 06:48:21 EST


On 06/17/2014 01:11 AM, Heiko Schocher wrote:
Driver for the TI TMP103.

The TI TMP103 is similar to the TMP102. It differs from the TMP102
by having only 8 bit registers.

Signed-off-by: Heiko Schocher <hs@xxxxxxx>

[ ... ]
+#define TMP103_CONF_SD (TMP103_CONF_M0 | TMP103_CONF_M1)

Hello Heiko,

I thought this needs to be TMP103_CONF_M1, but from the datasheet it looks
like it does not matter if M0 is set if M1 is set as well. Did you test it,
though, to make sure that it works ? I feel slightly uncomfortable with it.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/