Re: [PATCH] ARM: STi: DT: Properly define sti-ethclk & stmmaceth for stih415/6

From: Peter Griffin
Date: Mon Jun 16 2014 - 05:19:53 EST


Hi Lee,

> > ethernet1: dwmac@fef08000 {
> > @@ -189,11 +189,11 @@
> > st,syscon = <&syscfg_sbc>;
> >
> > resets = <&softreset STIH415_ETH1_SOFTRESET>;
> > - reset-names = "stmmaceth";
> > + reset-names = "stmmaceth", "sti-ethclk";
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_mii1>;
> > clock-names = "stmmaceth";
> > - clocks = <&clk_s_a0_ls CLK_ETH1_PHY>;
> > + clocks = <&clk_s_a0_ls CLK_ICN_REG>, <&clk_s_a0_ls CLK_ETH1_PHY>;
>
> This looks wrong to me. You appear to have changed the reset-names
> instead of the clock-names here.

Whoops, your right, I'll send a V2 shortly.

Pete.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/