Re: [PATCH] gpio-pxa: gpio0 and gpio1 support on dt

From: Linus Walleij
Date: Thu Jun 12 2014 - 04:43:23 EST


On Thu, Jun 5, 2014 at 9:13 PM, Andrew Ruder
<andrew.ruder@xxxxxxxxxxxxxxx> wrote:

> pxa_gpio_probe() has some issues supporting the gpio0 and gpio1
> interrupts under device-tree - it never actually sets up the chain
> handler to get interrupts on edge detect for GPIO0 and GPIO1.
>
> Signed-off-by: Andrew Ruder <andrew.ruder@xxxxxxxxxxxxxxx>

Makes perfect sense. Can I have an ACK from some PXA
maintainer on this?

The PXA GPIO driver with it's messy irqchip registration looks
like a good candidate for switching to the gpiolib irqchip helpers
and rid some code. Just saying.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/