Re: [PATCH v3] leds: USB: HID: Add support for MSI GT683R led panels

From: Jiri Kosina
Date: Wed Jun 11 2014 - 07:25:55 EST


On Wed, 11 Jun 2014, Janne Kanniainen wrote:

> This driver adds support for USB controlled led panels that exists in MSI GT683R laptop
>
> Changes in v2:
> - sorted headers to alphabetic order
> - using devm_kzalloc
> - using BIT(n)
> - using usb_control_msg instead of usb_submit_urb
> - removing unneeded code
>
> Changes in v3:
> - implemented as HID device
> - some cleanups and bug fixes
>
> Signed-off-by: Janne Kanniainen <janne.kanniainen@xxxxxxxxx>

Thanks for the driver. Johan, as you did a very good job reviewing this
before I managed to get to it, I'd be glad to put your Reviewed-by: to the
commit before commiting it, if you are going to provide it.

Thanks,

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/