Re: [PATCH 1/2] sched: Rework migrate_tasks()

From: Srikar Dronamraju
Date: Wed Jun 11 2014 - 07:24:26 EST


* Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> [2014-06-11 13:52:10]:

>
> Currently migrate_tasks() skips throttled tasks,
> because they are not pickable by pick_next_task().
>

Before migrate_tasks() is called, we do call set_rq_offline(), in
migration_call().

Shouldnt this take care of unthrottling the tasks and making sure that
they can be picked by pick_next_task().

> These tasks stay on dead cpu even after they
> becomes unthrottled. They are not schedulable
> till user manually changes their affinity or till
> cpu becomes alive again.
>

If we are still seeing tasks not being picked by pick_next_task(), then
can it probably mean that rq->rd was NULL?

--
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/