Re: [PATCH 1/2] sched: Rework migrate_tasks()

From: Peter Zijlstra
Date: Wed Jun 11 2014 - 06:57:43 EST


On Wed, Jun 11, 2014 at 01:52:10PM +0400, Kirill Tkhai wrote:
>
> Currently migrate_tasks() skips throttled tasks,
> because they are not pickable by pick_next_task().
>
> These tasks stay on dead cpu even after they
> becomes unthrottled. They are not schedulable
> till user manually changes their affinity or till
> cpu becomes alive again.
>
> But for user this looks completely untransparent:
> task hangs, but it's not obvious what he has to do,
> because kernel does not report any problem.
>
> This situation may easily be triggered intentionally.
> Playing with extremely small cpu.cfs_quota_us causes
> it almost in 100% cases. In usual life it's very rare,
> but still possible for some unhappy user.
>

How about fixing the unthrottle code to validate the affinity?

Attachment: pgpmCGH2E3hv7.pgp
Description: PGP signature