Re: [PATCH] ip_tunnel: fix i_key matching in ip_tunnel_find

From: David Miller
Date: Wed Jun 11 2014 - 03:43:56 EST


From: Dmitry Popov <ixaphire@xxxxxxxxxx>
Date: Sun, 8 Jun 2014 03:03:08 +0400

> Some tunnels (though only vti as for now) can use i_key just for internal use:
> for example vti uses it for fwmark'ing incoming packets. So raw i_key value
> shouldn't be treated as a distinguisher for them. ip_tunnel_key_match exists for
> cases when we want to compare two ip_tunnel_parms' i_keys.
>
> Example bug:
> ip link add type vti ikey 1 local 1.0.0.1 remote 2.0.0.2
> ip link add type vti ikey 2 local 1.0.0.1 remote 2.0.0.2
> spawned two tunnels, although it doesn't make sense.
>
> Signed-off-by: Dmitry Popov <ixaphire@xxxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/