Re: [PATCH] x86/tlb_uv: Fixing some memory allocation failure in x86 UV

From: Thomas Gleixner
Date: Tue Jun 10 2014 - 19:28:27 EST


On Tue, 10 Jun 2014, H. Peter Anvin wrote:

> On 06/10/2014 12:35 AM, Zhouyi Zhou wrote:
> > Fixing some memory allocation failure handling in x86 UV
> >
> > Signed-off-by: Zhouyi Zhou <yizhouzhou@xxxxxxxxx>
>
> Sorry, this really isn't enough description for this size of a patch.

Correction: This is not a proper description for any patch.

"some" is wrong to begin with.

Either we fix a particular issue or we address all of them, but "some"
means: We fixed a few, but we did not care about the rest.

Aside of that, I agree. The changelog is disjunct from the patch
itself.

Thanks,

tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/