Re: [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check

[Dirk Brandewie]

On 06/09/2014 10:21 PM, Viresh Kumar wrote:
> On 10 June 2014 02:30, Stratos Karafotis <stratosk@xxxxxxxxxxxx> wrote:
> > We check the CPU ID during driver init. There is no need
> > to do it again per logical CPU initialization.
> >
> > So, remove the duplicate check.
> >
> > Signed-off-by: Stratos Karafotis <stratosk@xxxxxxxxxxxx>
> > ---
> >   drivers/cpufreq/intel_pstate.c | 6 ------
> >   1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> > index aebd457..4e7f492 100644
> > --- a/drivers/cpufreq/intel_pstate.c
> > +++ b/drivers/cpufreq/intel_pstate.c
> > @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> >
> >   static int intel_pstate_init_cpu(unsigned int cpunum)
> >   {
> > -
> > -       const struct x86_cpu_id *id;
> >          struct cpudata *cpu;
> >
> > -       id = x86_match_cpu(intel_pstate_cpu_ids);
> > -       if (!id)
> > -               return -ENODEV;
> > -
> >          all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL);
> >          if (!all_cpu_data[cpunum])
> >                  return -ENOMEM;
>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Acked-by: Dirk Brandewie <dirk.j.brandewie@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/