Re: [PATCH] arch: tile: kernel: unaligned.c: Cleaning up uninitialized variables

[Rickard Strandqvist]

Hi Chris

So uint max was a better default value.
Yeah, good it came into use. The main thing that the code got a proper review :)


Kind regards
Rickard Strandqvist


2014-06-08 3:41 GMT+02:00 Chris Metcalf <cmetcalf@xxxxxxxxxx>:
> On 5/31/2014 7:00 PM, Rickard Strandqvist wrote:
>>
>> There is a risk that the variable will be used without being initialized.
>>
>> This was largely found by using a static code analysis program called
>> cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist<rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
>> ---
>>   arch/tile/kernel/unaligned.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> Thanks!  Taken into the tile tree with some slight modifications (initialize
> variables to -1 not 0, and remove the resulting dead code in find_regs).
>
> --
> Chris Metcalf, Tilera Corp.
> http://www.tilera.com
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/