RE: [PATCH v2] ARM: fix debug prints relevant to PCI devices

[Vidya Sagar]

oops... I missed it somehow. I'll post a new patch.

> -----Original Message-----
> From: Joe Perches [mailto:joe@xxxxxxxxxxx]
> Sent: Friday, June 06, 2014 9:53 AM
> To: Vidya Sagar
> Cc: linux@xxxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx;
> wangyijing@xxxxxxxxxx; thierry.reding@xxxxxxxxx;
> jason@xxxxxxxxxxxxxx; will.deacon@xxxxxxx; Stephen Warren; Krishna
> Thota; sagar.tv@xxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2] ARM: fix debug prints relevant to PCI devices
> 
> On Fri, 2014-06-06 at 00:17 +0530, Vidya Sagar wrote:
> > * replaced printk with pr_info
> []
> > diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
> []
> > @@ -354,9 +357,11 @@ void pcibios_fixup_bus(struct pci_bus *bus)
> >
> >  	/*
> >  	 * Report what we did for this bus
> > +	 * (only if the bus doesn't have even one PCIe device)
> >  	 */
> > -	printk(KERN_INFO "PCI: bus%d: Fast back to back transfers
> %sabled\n",
> > -		bus->number, (features & PCI_COMMAND_FAST_BACK) ?
> "en" : "dis");
> > +	if (!has_pcie_dev)
> > +		pr_info(KERN_INFO "PCI: bus%d: Fast back to back transfers
> %sabled\n",
> > +			bus->number, (features &
> PCI_COMMAND_FAST_BACK) ? "en" : "dis");
> 
> when you convert to pr_<level> you need to remove the KERN_<LEVEL>
> from the format string too.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/