Re: [PATCH 00/32] perf and kconfig kbuild (2nd try)

From: Alexis Berlemont
Date: Wed Jun 04 2014 - 07:12:28 EST


On Wed, Jun 4, 2014 at 3:59 AM, David Ahern <dsahern@xxxxxxxxx> wrote:
> On 6/3/14, 4:05 PM, Alexis Berlemont wrote:
>>
>> Alexis Berlemont (29):
>> kbuild: add support of custom paths for "auto.conf*" files
>> perf kbuild: fix recursive invocation of config/features-checks
>> perf kbuild: store in config-detected missing variables (libdir, ...)
>> perf kbuild: remove useless #ifdef directives
>> perf kbuild: fix a link issue if BUILTIN_TRACE is disabled
>> perf kbuild: add missing files and missing flags in Kbuild files
>> perf kbuild: update kbuild files according to last changes
>> perf kbuild: remove legacy slang-related build variables
>> perf kbuild: remove legacy libaudit-related build variables
>> perf kbuild: remove legacy libgtk2-related build variables
>> perf kbuild: remove legacy libperl-related build variables
>> perf kbuild: remove legacy timerfd-related build variable
>> perf kbuild: remove legacy demangle-related build variables
>> perf kbuild: remove legacy on_exit-related build variable
>> perf kbuild: remove legacy backtrace-related build variable
>> perf kbuild: remove legacy numa-related build variable
>> perf kbuild: remove legacy bionic-related build variable
>> perf kbuild: remove legacy libelf-related build variables (1st part)
>> perf kbuild: remove legacy libelf-related build variables (2nd part)
>> perf kbuild: remove legacy libdwarf-related build variables
>> perf kbuild: remove legacy libpython-related build variable
>> perf kbuild: add generated Kconfig build-test cases
>> perf kbuild: fix installation of traceevent plugins
>> perf kbuild: fix tarpkg target in tests/make
>> perf kbuild: update Kbuild files with new and removed sources
>> perf kbuild: update build test configurations
>> perf kbuild: relocate the configs generating script
>> perf kbuild: minor changes
>> perf kbuild: remove Makefile.perf
>
>
>
> In general you are missing commit messages that explain why the patch is
> needed -- what does it do, what is changed. The code should evolve from
> where it is to where you want it to be in small focused patches that do not
> break compiles or features (important for git-bisect).

OK. I will gather the various commits in less large set of patches.
>
> For patches that you are leveraging from Jiri odds are they need to be
> updated for what has happened over the past year since Jiri's last effort on
> this. I suggest doing the updates in line with Jiri's patch and add a
> comment of what was added to Jiri's patch.
>

OK. Let's try again. Many thanks for your answer.

> Also add Namhyung Kim <namhyung@xxxxxxxxxx> to your CC list.
>
> Thanks,
> David

Alexis.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/