Re: [PATCH 4/6] sched,idle: Clear polling before descheduling the idle thread

[Peter Zijlstra]

On Tue, Jun 03, 2014 at 05:29:50PM -0700, Andy Lutomirski wrote:
> @@ -229,6 +234,8 @@ static void cpu_idle_loop(void)
>  		 */
>  		preempt_set_need_resched();
>  		tick_nohz_idle_exit();
> +		__current_clr_polling();
> +		smp_mb__after_clear_bit();

barriers always need a comment, and I'm not entirely sure why you put
this one here.

Merging the NR set and POLLING tests into a single atomic made the
entire barrier situation somewhat more complicated and I really need to
rethink that.

>  		schedule_preempt_disabled();
>  	}
>  }
> -- 
> 1.9.3
>

Attachment: pgpijXshUyQIi.pgp
Description: PGP signature