Re: [PATCH v2 0/4] Emulate VMXON region correctly

[Jan Kiszka]

On 2014-06-03 22:11, Bandan Das wrote:
> Paolo Bonzini <pbonzini@xxxxxxxxxx> writes:
> 
>> Il 06/05/2014 08:19, Bandan Das ha scritto:
>>> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=54521
>>>
>>> The vmxon region is unused by nvmx, but adding these checks
>>> are probably harmless and may detect buggy L1 hypervisors in
>>> the future!
>>
>> Applied to kvm/queue, unit test patches are welcome (hint, hint!).
> 
> Jan and Paolo,
> 
> Ok, I thought a little bit about this and I am wondering what 
> kind of tests we could have here. All the changes are pure 
> checks and no data is returned back to the guest. The
> vmxon code in kvm-unit-tests already does the right thing i.e
> sets the revision identifier, allocs a page for the region etc

Then try to do the wrong thing in the unit test and validate that you
get the right error report from the emulated VMX hardware.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/