Re: [PATCH v2] coccinelle: Check for missing NULL terminators in of_device_id tables

From: Julia Lawall
Date: Tue Jun 03 2014 - 14:14:28 EST


On Tue, 3 Jun 2014, Stephen Boyd wrote:

> On 06/03/14 03:15, Julia Lawall wrote:
> > Failure to terminate an of_device_id table can lead to confusing
> > failures depending on where the compiler places the array. Add a
> > check to make sure these tables are terminated. Thanks to Mitchel
> > Humpherys for coming up with the pattern initially.
> >
> > Cc: Mitchel Humpherys <mitchelh@xxxxxxxxxxxxxx>
> > Cc: Julia Lawall <Julia.Lawall@xxxxxxx>
> > Cc: Gilles Muller <Gilles.Muller@xxxxxxx>
> > Cc: Nicolas Palix <nicolas.palix@xxxxxxx>
> > Cc: Grant Likely <grant.likely@xxxxxxxxxx>
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> > Acked-by: Grant Likely <grant.likely@xxxxxxxxxx>
> > Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx>
> >
> > ---
> >
> > v3: Removed unneeded rule bad_of_table. Placed * in context rule on the
> > closing brace; putting it on the field caused all fields to be marked.
> >
>
>
> These seem like only minor changes. Why was my authorship removed?

Probably because I don't know how to provide a new vesion of the patch
properly. What should I have done? There were quite a lot of
modifications. It seemed easier to just send a complete new version.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/