Re: [PATCH v4] pinctrl: to avoid duplicated calling enable_pinmux_setting for a pin

[Stephen Warren]

On 06/03/2014 01:48 AM, FanWu wrote:
> On 06/03/2014 03:37 PM, fwu@xxxxxxxxxxx wrote:
>> From: Fan Wu <fwu@xxxxxxxxxxx>
>>
>> What the patch did:
>> 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in
>> each time of
>>    calling pinctrl_select_state
>> 2.Remove the HW disable operation in in pinmux_disable_setting function.
>> 3.Remove the disable ops in struct pinmux_ops
...
> For the "signed-off" part, I added the "Stephen" because I change the
> code inline comments according to the suggestion from Stephen.

The point is that you can NEVER write S-o-b for someone else, only for
yourself. Given the small contribution from me in this patch, the
following would be better ways to credit me:

1) Not bother since it's a tiny comment

2) In patch description:
(includes comment fixes from Stephen Warren)

3) In patch description final paragraph, before your S-o-b:
Based-on-work-by: Stephen Warren <swarren@xxxxxxxxxx>

(although (3) isn't really appropriate here, since my contribution was
tiny compared to the overall patch, and came after the original patch
rather than being inspiration for it)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/