Re: [PATCH -mm] mincore: apply page table walker on do_mincore() (Re: [PATCH 00/10] mm: pagewalk: huge page cleanups and VMA passing)

From: Dave Hansen
Date: Tue Jun 03 2014 - 11:59:53 EST


On 06/02/2014 11:18 PM, Naoya Horiguchi wrote:
> + /*
> + * Huge pages are always in RAM for now, but
> + * theoretically it needs to be checked.
> + */
> + present = pte && !huge_pte_none(huge_ptep_get(pte));
> + for (; addr != end; vec++, addr += PAGE_SIZE)
> + *vec = present;
> + cond_resched();
> + walk->private += (end - addr) >> PAGE_SHIFT;

That comment is bogus, fwiw. Huge pages are demand-faulted and it's
quite possible that they are not present.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/