Re: [PATCH] MAINTAINERS: drop two usb-serial subdriver entries

From: Johan Hovold
Date: Mon Jun 02 2014 - 03:16:42 EST


On Sun, Jun 01, 2014 at 10:45:59AM -0700, Greg Kroah-Hartman wrote:
> On Sun, Jun 01, 2014 at 11:32:17AM +0200, Johan Hovold wrote:
> > Remove the remaining two obsolete usb-serial subdriver entries from
> > MAINTAINERS, which were missed in the recent purge by commit
> > f896b7968b62 ("USB: Maintainers change for usb serial drivers").
> >
> > Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
> > ---
> > MAINTAINERS | 12 ------------
> > 1 file changed, 12 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 51ebb779c5f3..68599b26f514 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -9298,12 +9298,6 @@ S: Maintained
> > F: drivers/usb/host/isp116x*
> > F: include/linux/usb/isp116x.h
> >
> > -USB KAWASAKI LSI DRIVER
> > -M: Oliver Neukum <oliver@xxxxxxxxxx>
> > -L: linux-usb@xxxxxxxxxxxxxxx
> > -S: Maintained
> > -F: drivers/usb/serial/kl5kusb105.*
> > -
> > USB MASS STORAGE DRIVER
> > M: Matthew Dharm <mdharm-usb@xxxxxxxxxxxxxxxxxx>
> > L: linux-usb@xxxxxxxxxxxxxxx
> > @@ -9331,12 +9325,6 @@ S: Maintained
> > F: Documentation/usb/ohci.txt
> > F: drivers/usb/host/ohci*
> >
> > -USB OPTION-CARD DRIVER
> > -M: Matthias Urlichs <smurf@xxxxxxxxxxxxxx>
> > -L: linux-usb@xxxxxxxxxxxxxxx
> > -S: Maintained
> > -F: drivers/usb/serial/option.c
>
> Why are we taking away the maintainership of these individual drivers
> from these developers? I had no problem giving you the drivers I was
> supposed to be in charge of, but I need a signed-off-by from Matthias
> and Oliver for these if they want to do the same.

I honestly thought you had just missed these entries when you removed
individual maintainership for the other usb-serial drivers with the
motivation that the developers were not around and that maintainership
for individual drivers did not make much sense anymore (as consolidation
proceeds, I read). (These two entries were also not grouped with the
others.)

Oliver and perhaps also Mathias are still around, but the option driver
is now down to about 200 LOC (including boilerplate) when not counting
the id table, while the kl5kusb105 is currently at about 400 LOC
(including boilerplate) since I converted it to use the generic
implementation a few years ago.

Oliver and Mathias, what do you think of this? Would you be willing to
sign off on this patch?

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/