Re: [PATCH] staging: rtl8192u: r8192U_core.c: Cleaning up uninitialized variables

From: Rickard Strandqvist
Date: Sun Jun 01 2014 - 17:23:18 EST


Hi Dan

I agree, this looks strange.
Have been looking for a while in history with, to see if the code has
been removed. I start my search using cppcheck for over three months
ago.
But could not find anything. Sorry about that :-(

But I'll make a patch that completely removes testing variable then instead?


Best regards
Rickard Strandqvist


2014-06-01 22:37 GMT+02:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> On Sun, Jun 01, 2014 at 03:28:35PM +0200, Rickard Strandqvist wrote:
>> There is a risk that the variable will be used without being initialized.
>>
>> This was largely found by using a static code analysis program called cppcheck.
>>
>
> I've looked at the code, but I don't see this variable actually used
> anywhere. What is the exact cppcheck warning message?
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/