Re: [PATCH v4 00/15] Thunderbolt driver for Apple MacBooks

[Matthew Garrett]

On Sun, 2014-06-01 at 12:11 +0200, Andreas Noever wrote:
> On Sun, Jun 1, 2014 at 1:51 AM, Matthew Garrett
> <matthew.garrett@xxxxxxxxxx> wrote:
> > This seems to be working well on my MBP. It appears to broadly work on
> > my Mac Pro, which has Thunderbolt 2 hardware - I added the PCI ID, and
> > loading the thunderbolt driver after the device is plugged in works, but
> > it won't recognise hotplug events. I don't appear to get any interrupts
> > from the Thunderbolt controller. Any idea what might be happening there?
> So the communication with the controller works (dmesg dumps a list of
> ports etc.)? Do you get plug events ("resetting error on port ...")?
> You could try to play around with tb_plug_events_active, if you want
> to experiment. I can also take another look at what OS X does once I
> get back to my workstation (when I worked on this part falcon ridge
> was not jet released, so maybe they do things differently now).

Yeah, that was it. I'll mail the patch separately.


> > As far as the quirks go - perhaps something like this would be
> > reasonable, rather than maintaining a list of machines?
> I have obtained ACPI dumps from a late 2013 MBP and from a MacPro
> (both are falcon ridge devices) and these contain a few firmware
> changes. For example SXIO, SXIL and SXLV are gone so the shutdown
> quirk will fail. With some luck that means that the shutdown quirk is
> no longer required for falcon ridge hardware.

Yeah, it seems I don't need the suspend quirk - the NHI is still there
without it. I still think we should make the quirk general rather than
tying it to the machines, the worst case is that it'll just do nothing.

-- 
Matthew Garrett <matthew.garrett@xxxxxxxxxx>