Re: [PATCH] Revert "staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()"

From: Greg KH
Date: Thu May 29 2014 - 12:07:34 EST


On Thu, May 29, 2014 at 04:01:27PM +0900, Daeseok Youn wrote:
> This reverts commit 0ade4a34fd439d62df46937e8f3e584eb0879579.
>
> This patch removes kfree for serial_ports in dgap_tty_register_ports()
> if the "brd->printer_ports" allocation fails and serial_ports may be
> freed by calling dgap_tty_uninit() within other patch.
> That patch has an error handling but incomplete cleanup
> so it need to call kfree() for brd->serial_ports in
> dgap_tty_register_ports().
>
> Conflicts:
>
> drivers/staging/dgap/dgap.c
> ---
> drivers/staging/dgap/dgap.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)

-ENOSIGNEDOFFBY :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/