Re: remap_file_pages() use

From: Jeff Smith
Date: Mon May 26 2014 - 09:38:43 EST


OK, I misinterpreted "the overlapped part of the mapping(s) will be
discarded" as discarding the -new- mappings. My objections about
needing a replacement for remap_file_pages() are gone, but my concerns
about existing code still remain.
--Jeff

On Mon, May 26, 2014 at 8:35 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
> Il 26/05/2014 15:24, Jeff Smith ha scritto:
>
>> Your addr2 mmap() call is a bit incorrect semantically and
>> syntactically (you skipped the length arg). The addr2 request will
>> fail because mmap() does not implicitly munmap() occupied virtual
>> address space.
>
>
> With MAP_FIXED it does. It is in the man page.
>
> Paolo
>
>
>> Even if you did that, the following still has a race
>> condition between the addr2 request and another thread grabbing the
>> same virtual space, which nothing short of a lock on all threads'
>> mmap()-ing logic can protect:
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/