Re: [PATCH net-next 2/4] bridge: adhere to querier election mechanism specified by RFCs

From: David Miller
Date: Fri May 23 2014 - 23:37:42 EST


From: Linus Lüssing <linus.luessing@xxxxxx>
Date: Wed, 21 May 2014 10:59:00 +0200

> + if (saddr <= br->ip4_querier.addr.u.ip4)
> + goto update;

It is clear to me that you should be making these comparisons in cpu
endianness.

Otherwise the code will handle the same situations differently
on big-endian vs. little-endian machines.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/