Re: [PATCHv2 00/14] perf tools: Speedup DWARF unwind

From: Jiri Olsa
Date: Fri May 23 2014 - 04:14:20 EST


ping ;-)

thanks,
jirka

On Thu, May 15, 2014 at 07:23:21PM +0200, Jiri Olsa wrote:
> hi,
> trying to speedup DWARF unwind report code by factoring
> related code:
> - caching sample's registers access
> - keep dso data file descriptor open for the
> life of the dso object
> - replace dso cache code by mapping dso data file
> directly for the life of the dso object
>
> The speedup is mainly for libunwind unwind. The libdw will benefit
> mainly from cached registers access, because it handles dso data
> accesses by itself.. and anyway it's still faster ;-).
>
> v2 changes:
> - adding limit for open dso objects with sort of LRU
> mechanism to pick up and close dso objects if we
> are over the limit
> - file mmaping changes are omitted, because I couldn't prove
> the improvement exactly, will resubmit later
> - added dso close logic in case of no memory
> - added tests
>
> On 10GB perf data file with dwarf unwind data I've got
> around 30% speed up.
>
> Also reachable in here:
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> perf/core_unwind_speedup
>
> thanks,
> jirka
>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx>
> Cc: David Ahern <dsahern@xxxxxxxxx>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Jean Pihet <jean.pihet@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
> Jiri Olsa (14):
> perf tools: Cache register accesses for unwind processing
> perf tools: Separate dso data related variables
> perf tools: Add data_fd into dso object
> perf tools: Add global list of opened dso objects
> perf tools: Add global count of opened dso objects
> perf tools: Cache dso data file descriptor
> perf tools: Add file size check and factor dso__data_read_offset
> perf tools: Allow to close dso fd in case of open failure
> perf tools: Add dso__data_* interface descriptons
> perf tests: Spawn child for each test
> perf tests: Allow reuse of test_file function
> perf tests: Add test interface for dso data fd limit
> perf tests: Add test for caching dso file descriptors
> perf tests: Add test for closing dso objects on EMFILE error
>
> tools/perf/tests/builtin-test.c | 42 ++++++++++++++-
> tools/perf/tests/dso-data.c | 256 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> tools/perf/tests/tests.h | 2 +
> tools/perf/util/dso.c | 274 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------
> tools/perf/util/dso.h | 56 +++++++++++++++++++-
> tools/perf/util/event.h | 5 ++
> tools/perf/util/perf_regs.c | 10 +++-
> tools/perf/util/perf_regs.h | 4 +-
> tools/perf/util/unwind-libunwind.c | 4 +-
> 9 files changed, 617 insertions(+), 36 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/