Re: [PATCH] arch: cris: arch-v32: drivers: axisflashmap.c: Cleaning up inconsistent NULL checks

From: Jesper Nilsson
Date: Fri May 23 2014 - 03:00:27 EST


On Fri, May 23, 2014 at 12:00:09AM +0200, Rickard Strandqvist wrote:
> Cleaning up inconsistent NULL checks.
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.

... and is a false positive.

We can't enter this if-block unless ptable_head is set,
which is only set if main_mtd is set.

It might be useful to add it anyways, but there's a refactoring
needed for the axisflashmaps, so I'll keep it for then.

/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/