Re: [PATCH v3 6/7] Documentation: add the Marvell Berlin pinctrl documentation

[Linus Walleij]

On Fri, May 16, 2014 at 6:47 PM, Antoine TÃnart
<antoine.tenart@xxxxxxxxxxxxxxxxxx> wrote:
> Linus,

>> > +sm_pinctrl: pin-controller@0 {
>> > +       compatible = "marvell,berlin2q-sysmgr-pinctrl";
>> > +       reg = <0xfc0000 0x44>;
>> > +
>> > +       uart0_pmux: uart0-pmux {
>> > +               marvell,groups = "GSM12", "GSM13";
>> > +               marvell,function = "uart0";
>> > +       };
>> > +}
>>
>> I feel like ... can't we just standardize that and make it a common
>> pinctrl binding, and name the properties "groups" and "function"
>> for a family of pin controllers just mapping N groups to 1 function?
>>
>> I will merge the patches as are, but maybe we can make it generic
>> on top of this before the merge window?
>
> Do you mean just changing:
>
> s/marvell,groups/groups/
> s/marvell,function/function/
>
> and updating the documentation ?

To the pinctrl.txt document as generic bindings.
Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt

That and maybe moving some of the parsing into the pinctrl-utils.

> If so, I can definitely do that.

No big deal, we're a bit late on it. But if you like the looks of it,
please send a patch like that.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/