Re: skbuff truesize incorrect.

From: Jim Baxter
Date: Thu May 22 2014 - 16:21:43 EST


On 22/05/14 20:59, Eric Dumazet wrote:
> On Thu, 2014-05-22 at 20:39 +0100, Jim Baxter wrote:
>
>> I now think that the correct solution here is to create a new smaller
>> skb and copy the data from the sub packets into it.
>
> For low speed devices, this is indeed the best way.
>
> (this is called copybreak in some nic drivers)
>
>
>
Thank you Eric.

It is USB device that can handle 480Mbits/s so a middle speed device.

It looks like it is the normal trade off of speed versus memory. Either
I can use skb_clone for speed but that will impact memory with multiple
skb's of 16k or I copy the data to keep the memory usage low. Though
copying 2k of data into an skb will not likely be a massive overhead.

Jim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/