Re: [PATCH 2/3] of: Make of_find_node_by_path() handle /aliases

From: Frank Rowand
Date: Wed May 21 2014 - 21:27:13 EST


On 5/21/2014 9:09 AM, Grant Likely wrote:
> On Tue, 20 May 2014 19:55:45 -0700, Frank Rowand <frowand.list@xxxxxxxxx> wrote:
>> On 5/13/2014 7:58 AM, Grant Likely wrote:
>>
>>> Make of_find_node_by_path() handle aliases as prefixes. To make this

< snip >

>>> ---
>>
>>> drivers/of/base.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++----
>>
>>> 1 file changed, 56 insertions(+), 4 deletions(-)
>>
>>
>>
>> Was this patch created against a tree that has modifications to device tree
>>
>> locking?
>> I get a hang due to deadlock when I apply it. Patch to verify the
>> cause is below.
>
> Ummm... I may have forgotten to enable CONFIG_LOCKDEP when testing. Try
> the following fix, and can you please pass me that brown paper bag.

Nononono, I need to keep the bag for my own future use :-)

The following fix looks good and boots successfully on the dragonboard.

-Frank

>
> g.
>
> commit 35e9c5ae6c3d0b5eb91579f397d8e1ecb95ee711
> Author: Grant Likely <grant.likely@xxxxxxxxxx>
> Date: Thu May 22 01:04:17 2014 +0900
>
> dt: Create unlocked version of for_each_child_of_node()
>
> When iterating over nodes, sometimes it needs to be done when the DT
> lock is already held. This patch makes an unlocked version of the
> for_each_child_of_node() macro.
>
> Signed-off-by: Grant Likely <grant.likely@xxxxxxxxxx>

< snip >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/