Re: [PATCH] touchscreen: Introduce the use of the managed version of kzalloc

From: Dmitry Torokhov
Date: Wed May 21 2014 - 11:32:28 EST


Hi Himangi,

On Wed, May 21, 2014 at 08:44:05PM +0530, Himangi Saraogi wrote:
> - input_dev = input_allocate_device();
> + input_dev = devm_input_allocate_device(&pdev->dev);

...

> @@ -365,7 +359,6 @@ static int da9034_touch_remove(struct platform_device *pdev)
> struct da9034_touch *touch = platform_get_drvdata(pdev);
>
> input_unregister_device(touch->input_dev);

When using managed input devices calling input_unregister_device() is
unnecessary. Whole da9034_touch_remove() can be removed. I fixed it up
locally and applied your patch.

Thanks!

> - kfree(touch);
>
> return 0;
> }
> --
> 1.9.1
>

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/