Re: [PATCH V2 5/7] cpufreq: imx6q: don't initialize opp table

From: Shawn Guo
Date: Wed May 21 2014 - 10:16:48 EST


On Wed, May 21, 2014 at 03:07:36PM +0100, Sudeep Holla wrote:
> >@@ -376,7 +356,7 @@ static void __init imx6q_init_late(void)
> > imx6q_cpuidle_init();
> >
> > if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ)) {
> >- imx6q_opp_init();
> >+ imx6q_opp_check_speed_grading();
>
> [Query] Not exactly related to this patch, but asking it here to get clarified.
>
> This OPP limiting is done as part of late initcall and if the cpufreq driver is
> built in the kernel, there will be a small window where the OPPs not supported
> are still enabled ? Will that not be an issue if say performance governor is
> selected by default.

Even if cpufreq driver is built in the kernel, it won't be probed until
platform_device_register(&imx6q_cpufreq_pdev) is called. And we make
this call only after the OPP limiting.

Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/