Re: [PATCH V3 mmots] fs/hfsplus/wrapper.c: replace shift loop by ilog2

From: Fabian Frederick
Date: Tue May 20 2014 - 13:02:53 EST


On Tue, 20 May 2014 09:55:34 -0700
Davidlohr Bueso <davidlohr@xxxxxx> wrote:

> On Tue, 2014-05-20 at 18:43 +0200, Fabian Frederick wrote:
> > Replace while blocksize;shift by ilog2
>
> Fabian, please start getting into the habit of improving your
> changelogs. Unlike a lot of OSS projects, the kernel community (usually)
> takes pride in having good ones. You send a number of patches but rarely
> explain a key concept of software development in general: *WHY* do we
> need this.
>
> Thanks,
> Davidlohr
>

Hello Davidlohr,

You're absolutely right, I'll do my best to improve that in the future.

Regards,
Fabian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/