Re: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame

From: Lee Jones
Date: Tue May 20 2014 - 11:21:08 EST


> From 95f6ac368dbe352af0dfa2097b7d58b416447be5 Mon Sep 17 00:00:00 2001
> From: Aurabindo J <mail@xxxxxxxxxxxx>
> Date: Sat, 10 May 2014 15:16:58 +0530
> Subject: [PATCH] mfd: abx500-core: Fix compiler warning larger stack frame
>
> On systems with CONFIG_FRAME_WARN=1024, compiler warns the allocation of
> an object of struct device on stack. Make the allocation dynamically to
> fix the warning.
>
> drivers/mfd/abx500-core.c: In function âabx500_dump_all_banksâ:
> drivers/mfd/abx500-core.c:167:1: warning: the frame size of 1032 bytes
> is larger than 1024 bytes [-Wframe-larger-than=]
>
> Signed-off-by: Aurabindo J <mail@xxxxxxxxxxxx>
> ---
> drivers/mfd/abx500-core.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)

Looks good to me. I'll apply it until Linus complains.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/