Re: [PATCH 2/9] usb: gadget: net2280: Dont use magic numbers

From: Alan Stern
Date: Tue May 20 2014 - 10:52:48 EST


On Tue, 20 May 2014, Ricardo Ribalda Delgado wrote:

> Hello Alan
>
> In this case, there are only two family of devices supported by the
> driver. Maybe quirks are too much.
>
> At the end:
>
> ep->dev->pdev->vendor == PCI_VENDOR_ID_PLX_LEGACY
>
> is not much bigger than
>
> ep->dev->quirk_flag & PLX_NET2280_QUIRK
>
> But if you prefer the quirk I dont mind implementing it, but please as
> a follow-up patch, since there are 8 patches depending on this :)

It's not a big deal. Up to you.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/