Re: [PATCH V4] PM/OPP: discard duplicate OPPs

From: Viresh Kumar
Date: Tue May 20 2014 - 10:49:36 EST


On 20 May 2014 19:57, Nishanth Menon <nm@xxxxxx> wrote:
>> + pr_warn("%s: duplicate OPPs detected. Existing: freq: %lu, volt: %lu, enabled: %d. New: freq: %lu, volt: %lu, enabled: %d\n",
> dev_warn please? we already know the dev pointer. Also can we reduce
> this down to 80 character limit if possible?

breaking printk string into multiple line isn't suggested as it affects
readability and so I kept it this way. Another was was to break printk
itself intro two-three printk lines, but that would have looked bad
on console.

So, will retain it :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/