RE: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test

From: David Laight
Date: Tue May 20 2014 - 04:53:13 EST


From: Alan Stern
...
> > -static struct usb_request *
> > -net2280_alloc_request (struct usb_ep *_ep, gfp_t gfp_flags)
> > +static struct usb_request *net2280_alloc_request(struct usb_ep *_ep,
> > + gfp_t gfp_flags)
>
> What's with the extreme indentation on the continuation line? The
> style used here is for continuation lines to be indented by two stops
> relative to the first line.

Also why move the line break?
The Linux kernel has both styles, and the original one (with the
function name starting in column 1) makes it much easier to search
to the definition.

David



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/