RE: [PATCH 1/6] input: cyapa: rearchitecture driver to support function pointers

[Dudley Du]

Hi Dmitry,

Thanks for your advice, I will organize it and resubmit it as v2.

Thanks,
Dudley

> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx]
> Sent: Tuesday, May 20, 2014 11:48 AM
> To: Dudley Du
> Cc: Benson Leung; Daniel Kurtz; David Solda; linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/6] input: cyapa: rearchitecture driver to support function pointers
>
> Hi Dudley,
>
> On Wed, Apr 16, 2014 at 08:35:52AM +0000, Dudley Du wrote:
> > Re-architecture the driver to support function pointers, so it can support and integrate new devices later in one driver.
> > Including use async thread in device proble to speed up system boot time.
> > TEST=test on Chomebooks.
>
> There seems to be changes implementing aasync probing intermixed with the function pointers change, it had to be split out and justification needs to be provided - I am not quite convinced we should be doing this, at least not at individual driver level.
>
> Also instead of listing individual function pointers consider defining
>
> struct cyapa_ops {
>       void (*irq_handler)(struct cyapa *);
>       int (*set_power_mode)(struct cyapa *, u8, u16);
>       int (*bl_enter_func)(struct cyapa *);
>       ....
> };
>
> and use const pointer to it in cyapa_state. Then you can have gen3 and
> gen5 implementation separated into individual files and the rest forming cyapa core.
>
> Thanks.
>
> --
> Dmitry
This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/