RE: [PATCH] x86/mce: Clear a useless global variable in mce.c

From: Luck, Tony
Date: Mon May 19 2014 - 13:59:34 EST


- atomic_inc(&mce_entry);
-

I have used this in the past (in conjunction with an external debugger) to
diagnose problems (not all cpus showing up in the machine check handler).

But I suppose these can also be diagnosed from the "Timeout synchronizing ..."
message from mce_timed_out() [though with a bit less precision ... we know
that some cpus didn't show up, but we don't have a count of how many did,
or how many are missing.

If we print the value of "mce_callin" somewhere in mce_timed_out() ...
then I think we'd have equivalent functionality (in fact better - because
we don't need the external debugger to peek at mce_entry).

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/