Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[Dan Carpenter]

On Mon, May 19, 2014 at 12:49:03PM +0200, Jes Sorensen wrote:
> You should be running your tools against the staging tree automatically,
> that way you catch it before it hits the mainline tree.
>
> Just flooding mailing lists for the sake of flooding them doesn't add
> any value either.

We are used to handling the traffic.  Heh.  Don't worry about us.  ;)

I don't actually run static analysis on staging patches until they hit
linux-next, I only review the mailing list patches manually.  My review
process is built around mailing lists so creating a special process for
rtl8723au makes my life harder instead of easier.  Every subsystem has a
review process, it's not that we are treating you unfairly by asking you
to send your patches for review.

Btw, Greg doesn't rebase the staging tree so, once a patch is merged,
then it means it will hit mainline.  At that point, it is too late to
send a second version of the patch.

You should be running Sparse yourself as part of your own QC tests
before submitting patches to review.  http://lwn.net/Articles/205624/
It is a normal minimum requirement along with checkpatch.pl.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/