Re: [PATCH v9 0/3] Exynos 5410 support

From: Tomasz Figa
Date: Mon May 19 2014 - 06:51:53 EST


Hi Tarek,

On 19.05.2014 05:37, Tarek Dakhran wrote:
> The series of patches represent support of Exynos 5410 SoC
>
> The Exynos 5410 is the first Samsung SoC based on big.LITTLE architecture
>
> Patches add new platform description, support of clock controller and device
> tree for Exynos 5410.
>
> Has been build on Samsung Linux Kernel
> (branch: for-next, commit: ccf5511 ARM: EXYNOS: Add MCPM call-back functions)

This doesn't look like an up-to-date tip of that branch. There was a lot
of changes merged 2 days ago, especially from samsung-clk tree and your
patches won't apply and/or compile (at least patch 2/3). Are you sure
you didn't have a git fetch error?

Moreover I can still see the dts using full-path syntax, instead of
reference-based one and also no soc node, as I pointed in v8. [1]

[1] https://lkml.org/lkml/2014/4/26/59

Another thing is that I still see a custom fixed clock binding being
used for oscclk in the clock driver, while I believe I pointed in some
of the previous versions that generic fixed clock should be used.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/