Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

From: Tomasz Figa
Date: Mon May 19 2014 - 06:25:21 EST


Hi Tushar,

On 19.05.2014 09:16, Tushar Behera wrote:
> On 05/15/2014 11:02 PM, Tomasz Figa wrote:
>> This patch introduces a driver that handles configuration of CLKOUT pin
>> of Exynos SoCs that can be used to output certain clocks from inside of
>> the SoC to a dedicated output pin.
>>
>> Signed-off-by: Tomasz Figa <t.figa@xxxxxxxxxxx>
>> ---
>
> Tested the series on Exynos5420-based peach-pit board for audio playback
> (with an internal patch to set CLK_FIN_PLL as the parent of clkout).
>
> Tested-by: Tushar Behera <tushar.behera@xxxxxxxxxx>
>

Thank you for testing.

>> Example :
>> pmu_system_controller: system-controller@10040000 {
>> compatible = "samsung,exynos5250-pmu", "syscon";
>> reg = <0x10040000 0x5000>;
>> + #clock-cells = <0>;
>> + clock-names = "clkout0", "clkout1", "clkout2", "clkout3",
>> + "clkout4", "clkout8", "clkout9";
>> + clocks = <&clock CLK_OUT_DMC>, <&clock CLK_OUT_TOP>,
>> + <&clock CLK_OUT_LEFTBUS>, <&clock CLK_OUT_RIGHTBUS>,
>> + <&clock CLK_OUT_CPU>, <&clock CLK_XXTI>,
>> + <&clock CLK_XUSBXTI>;
>> };
>
> Adding an usage example in the documentation would be helpful.

Right, that's usually a good idea, I don't know why I haven't added one.
Thanks.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/