Re: [PATCH 3/4] atm: idt77252: Remove redundant error check

From: David Miller
Date: Sun May 18 2014 - 21:14:17 EST


From: Peter Senna Tschudin <peter.senna@xxxxxxxxx>
Date: Sat, 17 May 2014 20:22:59 +0200

> Remove double checks, and move the call to printk to the
> first check. Also adds KERN_WARNING to printk. The simplified version
> of the coccinelle semantic patch that fixes this issue is as follows:

The appropriate thing to use is pr_warning() rather than add
KERN_WARNING.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/