Re: [PATCH 1/2] staging: slicoss: rewrite eeprom checksum code

From: Joe Perches
Date: Sun May 18 2014 - 00:14:42 EST


On Sat, 2014-05-17 at 21:00 -0700, David Matlack wrote:
[]
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
[]
> +static inline u16 __reduce(u32 checksum)
> +{
> + u16 lower_16 = checksum & 0xFFFF;
> + u16 upper_16 = (checksum >> 16) & 0xFFFF;
> +
> + checksum = lower_16 + upper_16;
> +
> + if (checksum > 65535)
> + checksum -= 65535;
> +
> + return checksum;
> +}

The if seems unnecessary.

Perhaps declare a u16 return var or use

return lower_16 + upper_16;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/