Re: [PATCH] clk: tegra: Fix wrong value written to PLLE_AUX

From: Thierry Reding
Date: Sat May 17 2014 - 17:07:20 EST


On Fri, May 16, 2014 at 10:05:18AM -0600, Stephen Warren wrote:
> On 05/16/2014 08:31 AM, Thierry Reding wrote:
> > On Fri, May 16, 2014 at 04:50:20PM +0300, Tuomas Tynkkynen wrote:
> >> The value written to PLLE_AUX was incorrect due to a wrong variable
> >> being used.
> >>
> >> Signed-off-by: Tuomas Tynkkynen <ttynkkynen@xxxxxxxxxx>
> >> Tested-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
> >> ---
> >> This fix is required for the (upcoming) SATA support.
> >> drivers/clk/tegra/clk-pll.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
> > Tested-by: Thierry Reding <treding@xxxxxxxxxx>
> > Acked-by: Thierry Reding <treding@xxxxxxxxxx>
> >
> > Mike, Peter, it might be good to have this go into 3.16 as a
> > prerequisite for the upcoming SATA driver (which presumably won't be
> > ready until 3.17, but in that case it would be good to have this
> > prerequisite merged already).
>
> Probably even Cc: stable since it's a fix for a bug that I assume has
> been in a kernel release or two?

Yeah, I guess that makes sense. The bug isn't visible yet, but back-
porting to stable might save somebody else from chasing this if they
ever decide to backport PCIe, SATA or XUSB.

Thierry

Attachment: pgpfIwI_ESd0d.pgp
Description: PGP signature