Re: [PATCH V2 2/3] cpufreq: add support for intermediate (stable) frequencies

From: Viresh Kumar
Date: Sat May 17 2014 - 00:06:42 EST


On 17 May 2014 00:20, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
> s/Uset/Used.

:(

>> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
>> + unsigned int (*get_intermediate)(struct cpufreq_policy *policy,
>> + unsigned int index);
>
> Should get_intermediate be passed a struct cpufreq_freqs freqs rather
> than just the target index? That way, if the intermediate frequency
> varies depending on old/new frequencies, then the driver won't have to
> go look up the current frequency in order to implement that logic.

That can be done by simply doing policy->cur and we don't require to
get it from hardware again. So, probably should stay as is.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/