Re: [PATCH] Staging: gdm72xx: gdm_wimax: Fixed coding style issues.

From: Greg KH
Date: Fri May 16 2014 - 15:09:17 EST


On Mon, Apr 28, 2014 at 01:50:11PM -0500, Junsu Shin wrote:
> Fixed following coding style issues.
> - No space is necessary after a cast
> - Alignment should match open parenthesis
> - Braces {} should be used on all arms of this statement

You are doing 3 things, so this should be 3 patches at the least.
Remember, one patch per "thing".

> Signed-off-by: Junsu Shin <jsshin.dev@xxxxxxxxx>x

What is the trailing 'x' for?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/