Re: [PATCH 3/5] workqueue: Create low-level unbound workqueues cpumask

From: Tejun Heo
Date: Fri May 16 2014 - 15:00:51 EST


On Fri, May 16, 2014 at 01:52:48PM -0500, Christoph Lameter wrote:
> On Fri, 16 May 2014, Tejun Heo wrote:
>
> > On Fri, May 16, 2014 at 12:52:26PM -0500, Christoph Lameter wrote:
> > > On Fri, 16 May 2014, Frederic Weisbecker wrote:
> > >
> > > > It works on a lower-level than the per WQ_SYSFS workqueues cpumask files
> > > > such that the effective cpumask applied for a given unbound workqueue is
> > > > the intersection of /sys/devices/virtual/workqueue/$WORKQUEUE/cpumask and
> > > > the new /sys/devices/virtual/workqueue/cpumask_unbounds file.
> > >
> > > Why is there "virtual" directory in the path? Workqueues are "virtual"
> > > devices?
> >
> > I ain't an actual one. That apparently is the preferred place to
> > present software constructs like workqueues in sysfs.
>
> Could we fix that? A workqueue is not a device but more a kernel setting.
>
> /sys/kernel/workqueue/.... ?

Right, that could have been more in line with slab files. It's
already too late tho. This has been exposed for quite a while now.
Urgh...

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/