Re: [PATCH 2/2] sysrq,rcu: suppress RCU stall warnings while sysrq runs

From: Andrew Morton
Date: Thu May 15 2014 - 19:24:18 EST


On Tue, 29 Apr 2014 14:06:36 -0400 riel@xxxxxxxxxx wrote:

> From: Rik van Riel <riel@xxxxxxxxxx>
>
> Some sysrq handlers can run for a long time, because they dump a lot
> of data onto a serial console. Having RCU stall warnings pop up in
> the middle of them only makes the problem worse.
>
> This patch temporarily disables RCU stall warnings while a sysrq
> request is handled.
>
> ...
>
> drivers/tty/sysrq.c | 3 +++
> include/linux/rcupdate.h | 12 ++++++++++++
> kernel/rcu/update.c | 12 ++++++++++++

OK, what's going on here. Someone (of, I suspect, a Paulish nature)
has plucked out the rcu parts of this patch, put them in linux-next and
omitted the drivers/tty part. Very tricky!


I have done the opposite and have staged two patches against linux-next:

http://ozlabs.org/~akpm/mmots/broken-out/sysrq-rcu-ify-__handle_sysrq.patch
http://ozlabs.org/~akpm/mmots/broken-out/sysrqrcu-suppress-rcu-stall-warnings-while-sysrq-runs.patch

Please check, review, comment, etc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/