Re: [PATCH 1/1] fs/hfsplus/wrapper.c: replace min/casting by min_t

From: Joe Perches
Date: Thu May 15 2014 - 14:53:10 EST


On Thu, 2014-05-15 at 19:05 +0200, Fabian Frederick wrote:
> Also add * before function comments (it was not detected by
> kernel-doc)
[]
> diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
[]
> @@ -234,7 +234,7 @@ reread:
> sbi->alloc_blksz_shift = 0;
> while ((blocksize >>= 1) != 0)
> sbi->alloc_blksz_shift++;

Unrelated, but perhaps this while loop
should use fls instead.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/